netdev - Re: [PATCH net-next] netlink: specs: add big-endian byte-order for u32 IPv4 addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8564b02f-18f9-4132-ab69-5ee1babeb18c@fiberby.net>
Date: Tue, 25 Nov 2025 17:03:13 +0000
From: Asbjørn Sloth Tønnesen <ast@...erby.net>
To: Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc: Donald Hunter <donald.hunter@...il.com>, Jakub Kicinski
 <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, "Matthieu Baerts (NGI0)"
 <matttbe@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
 Jacob Keller <jacob.e.keller@...el.com>,
 Yuyang Huang <yuyanghuang@...gle.com>, Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH net-next] netlink: specs: add big-endian byte-order for
 u32 IPv4 addresses

On 11/25/25 11:20 AM, Hangbin Liu wrote:
> The fix commit converted several IPv4 address attributes from binary
> to u32, but forgot to specify byte-order: big-endian. Without this,
> YNL tools display IPv4 addresses incorrectly due to host-endian
> interpretation.
> 
> Add the missing byte-order: big-endian to all affected u32 IPv4
> address fields to ensure correct parsing and display.
> 
> Fixes: 1064d521d177 ("netlink: specs: support ipv4-or-v6 for dual-stack fields")
> Reported-by: Paolo Abeni <pabeni@...hat.com>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

LGTM

Reviewed-by: Asbjørn Sloth Tønnesen <ast@...erby.net>

I also checked how consistently defined the fields using the ipv6 display helper are,
and it looks like they could use some realignment too. Obviously not for this fix.

git grep -C6 'display-hint.*ipv6$' Documentation/netlink/specs/