netdev - Re: [PATCH net-next v1 4/5] net: bonding: add the READ_ONCE/WRITE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202511260755.PsI0heoq-lkp@intel.com>
Date: Wed, 26 Nov 2025 07:56:50 +0800
From: kernel test robot <lkp@...el.com>
To: Tonghao Zhang <tonghao@...aicloud.com>, netdev@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Tonghao Zhang <tonghao@...aicloud.com>,
	Jay Vosburgh <jv@...sburgh.net>, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Nikolay Aleksandrov <razor@...ckwall.org>,
	Hangbin Liu <liuhangbin@...il.com>
Subject: Re: [PATCH net-next v1 4/5] net: bonding: add the
 READ_ONCE/WRITE_ONCE for outside lock accessing

Hi Tonghao,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Tonghao-Zhang/net-bonding-use-workqueue-to-make-sure-peer-notify-updated-in-lacp-mode/20251125-164825
base:   net-next/main
patch link:    https://lore.kernel.org/r/20251125084451.11632-5-tonghao%40bamaicloud.com
patch subject: [PATCH net-next v1 4/5] net: bonding: add the READ_ONCE/WRITE_ONCE for outside lock accessing
config: loongarch-defconfig (https://download.01.org/0day-ci/archive/20251126/202511260755.PsI0heoq-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251126/202511260755.PsI0heoq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511260755.PsI0heoq-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/net/bonding/bond_main.c:1207:2: error: unterminated function-like macro invocation
    1207 |         WRITE_ONCE(bond->send_peer_notif,
         |         ^
   include/asm-generic/rwonce.h:58:9: note: macro 'WRITE_ONCE' defined here
      58 | #define WRITE_ONCE(x, val)                                              \
         |         ^
>> drivers/net/bonding/bond_main.c:6585:37: error: expected '}'
    6585 | MODULE_IMPORT_NS("NETDEV_INTERNAL");
         |                                     ^
   drivers/net/bonding/bond_main.c:1206:1: note: to match this '{'
    1206 | {
         | ^
   2 errors generated.


vim +1207 drivers/net/bonding/bond_main.c

  1203	
  1204	/* Peer notify update handler. Holds only RTNL */
  1205	static void bond_peer_notify_reset(struct bonding *bond)
  1206	{
> 1207		WRITE_ONCE(bond->send_peer_notif,
  1208			   bond->params.num_peer_notif *
  1209			   max(1, bond->params.peer_notif_delay);
  1210	}
  1211	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki