netdev - Re: [PATCH net-next v1] devlink: Notify eswitch mode changes to devlink monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251124202748.1816f4a0@kernel.org>
Date: Mon, 24 Nov 2025 20:27:48 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Jiri Pirko <jiri@...nulli.us>
Cc: Parav Pandit <parav@...dia.com>, Jiri Pirko <jiri@...dia.com>,
 netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, horms@...nel.org
Subject: Re: [PATCH net-next v1] devlink: Notify eswitch mode changes to
 devlink monitor

On Sat, 22 Nov 2025 10:14:35 +0100 Jiri Pirko wrote:
> >> For the sake of consistency, shouldn't the name be ESWITCH_NEW?  
> >
> >No preference on the naming, we can go with _NEW, tho, as I think Parav
> >is alluding to, we don't send _NEW when device is created (which would
> >be the natural fit for _NEW). Perhaps we should?  
> 
> devlink_notify(devlink, DEVLINK_CMD_NEW); - is this what you mean by
> "when device is created"?
> 
> If you mean DEVLINK_CMD_ESWITCH_NEW, then I believe we should send it
> both when
> 1) device is registered, right after we send devlink_notify(devlink, DEVLINK_CMD_NEW);
>    in devlink_notify_register()
> 2) when eswitch config is changed in devlink_nl_eswitch_set_doit()
> 
> And for the sake of completeness, we should also send
> DEVLINK_CMD_ESWITCH_DEL from devlink_notify_unregister().

Sounds right!