netdev - Re: [PATCH net-next 0/4] tcp: provide better locality for retransmit timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iKCz4xbbn8taZrC2VhsSWBALLDycfyH0UcJSv-pQ=CWog@mail.gmail.com>
Date: Wed, 26 Nov 2025 03:27:38 -0800
From: Eric Dumazet <edumazet@...gle.com>
To: Matthieu Baerts <matttbe@...nel.org>
Cc: Simon Horman <horms@...nel.org>, Neal Cardwell <ncardwell@...gle.com>, 
	Kuniyuki Iwashima <kuniyu@...gle.com>, Mat Martineau <martineau@...nel.org>, 
	Geliang Tang <geliang@...nel.org>, netdev@...r.kernel.org, eric.dumazet@...il.com, 
	"David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 0/4] tcp: provide better locality for retransmit timer

On Wed, Nov 26, 2025 at 3:23 AM Matthieu Baerts <matttbe@...nel.org> wrote:
>
> Hi Eric,
>
> On 24/11/2025 18:50, Eric Dumazet wrote:
> > TCP stack uses three timers per flow, currently spread this way:
> >
> > - sk->sk_timer : keepalive timer
> > - icsk->icsk_retransmit_timer : retransmit timer
> > - icsk->icsk_delack_timer : delayed ack timer
> >
> > This series moves the retransmit timer to sk->sk_timer location,
> > to increase data locality in TX paths.
> >
> > keepalive timers are not often used, this change should be neutral for them.
> >
> > After the series we have following fields:
> >
> > - sk->tcp_retransmit_timer : retransmit timer, in sock_write_tx group
> > - icsk->icsk_delack_timer : delayed ack timer
> > - icsk->icsk_keepalive_timer : keepalive timer
> >
> > Moving icsk_delack_timer in a beter location would also be welcomed.
>
> Sorry for the delay, I didn't manage to look at it yesterday. I just
> wanted to say thank you for this series, and for having adapted MPTCP as
> well!
>
> Just in case, even if the series has already been applied:
>
> Acked-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>

Thanks for checking the series !