netdev - Re: [TEST] bond_macvlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251126071930.76b42c57@kernel.org>
Date: Wed, 26 Nov 2025 07:19:30 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org
Subject: Re: [TEST] bond_macvlan_ipvlan.sh flakiness

On Tue, 18 Nov 2025 07:13:02 -0800 Jakub Kicinski wrote:
> On Tue, 18 Nov 2025 06:03:17 +0000 Hangbin Liu wrote:
> > > Hmm, this one is suspicious. I can reproduce the ping fail on local.
> > > But no "otherhost" issue. I will check the failure recently.    
> > 
> > This looks like a time-sensitive issue, with
> > 
> > diff --git a/tools/testing/selftests/drivers/net/bonding/bond_macvlan_ipvlan.sh b/tools/testing/selftests/drivers/net/bonding/bond_macvlan_ipvlan.sh
> > index c4711272fe45..947c85ec2cbb 100755
> > --- a/tools/testing/selftests/drivers/net/bonding/bond_macvlan_ipvlan.sh
> > +++ b/tools/testing/selftests/drivers/net/bonding/bond_macvlan_ipvlan.sh
> > @@ -30,6 +30,7 @@ check_connection()
> >         local message=${3}
> >         RET=0
> > 
> > +       sleep 1
> >         ip netns exec ${ns} ping ${target} -c 4 -i 0.1 &>/dev/null
> >         check_err $? "ping failed"
> >         log_test "${bond_mode}/${xvlan_type}_${xvlan_mode}: ${message}"
> > 
> > I run the test 100 times (vng with 4 cpus) and not able to reproduce it anymore.
> > That maybe why debug kernel works good.  
> 
> I see. I queued up a local change to add a 0.25 sec wait. Let's wait 
> a couple of days and see how much sleep we need here, this function 
> is called 96 times if I'm counting right.

Hi Hangbin!

The 0.25 sec sleep was added locally 1 week ago and 0 flakes since.
Would you mind submitting it officially?