netdev - Re: [PATCH net-next 3/4] tcp: introduce icsk->icsk_keepalive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVpQUBMth2wz+9E=6bVr3XwuQ42T-iR-YU0A-Ah48mLrfKN3Q@mail.gmail.com>
Date: Tue, 25 Nov 2025 16:06:57 -0800
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Neal Cardwell <ncardwell@...gle.com>, Matthieu Baerts <matttbe@...nel.org>, 
	Mat Martineau <martineau@...nel.org>, Geliang Tang <geliang@...nel.org>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com
Subject: Re: [PATCH net-next 3/4] tcp: introduce icsk->icsk_keepalive_timer

On Mon, Nov 24, 2025 at 9:50 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> sk->sk_timer has been used for TCP keepalives.
>
> Keepalive timers are not in fast path, we want to use sk->sk_timer
> storage for retransmit timers, for better cache locality.
>
> Create icsk->icsk_keepalive_timer and change keepalive
> code to no longer use sk->sk_timer.
>
> Added space is reclaimed in the following patch.
>
> This includes changes to MPTCP, which was also using sk_timer.
>
> Alias icsk->mptcp_tout_timer and icsk->icsk_keepalive_timer
> for inet_sk_diag_fill() sake.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>