netdev - Re: [PATCH net-next v12 05/12] virtio_net: Query and set flow filter caps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94c24884-4784-409f-99af-2d39efd3a81b@nvidia.com>
Date: Wed, 26 Nov 2025 00:11:47 -0600
From: Dan Jurgens <danielj@...dia.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: netdev@...r.kernel.org, jasowang@...hat.com, pabeni@...hat.com,
 virtualization@...ts.linux.dev, parav@...dia.com, shshitrit@...dia.com,
 yohadt@...dia.com, xuanzhuo@...ux.alibaba.com, eperezma@...hat.com,
 jgg@...pe.ca, kevin.tian@...el.com, kuba@...nel.org, andrew+netdev@...n.ch,
 edumazet@...gle.com
Subject: Re: [PATCH net-next v12 05/12] virtio_net: Query and set flow filter
 caps

On 11/24/25 4:54 PM, Michael S. Tsirkin wrote:
> On Wed, Nov 19, 2025 at 01:15:16PM -0600, Daniel Jurgens wrote:
>> index 4738ffe3b5c6..e84a305d2b2a 100644
>> --- a/drivers/virtio/virtio_admin_commands.c
>> +++ b/drivers/virtio/virtio_admin_commands.c
>> @@ -161,6 +161,8 @@ int virtio_admin_obj_destroy(struct virtio_device *vdev,
>>  	err = vdev->config->admin_cmd_exec(vdev, &cmd);
>>  	kfree(data);
>>  
>> +	WARN_ON_ONCE(err);
>> +
>>  	return err;
>>  }
> 
> 
> The reason I suggested WARN_ON_ONCE is because callers generally can not
> handle errors. if you return int you assume callers will do that so then
> warning does not make sense.
> 
> Bottom line - make this return void.
> 
> 

Done, also, this hunk was misplaced, moved it to the patch this function
was introduced.