netdev - Re: [PATCH net-next] net: restore napi_consume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+MBWPK5xrxht4Ot-i6pP-OfNtStG8_nMXvjRzf-Vhukg@mail.gmail.com>
Date: Thu, 27 Nov 2025 08:10:19 -0800
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com, 
	andrew+netdev@...n.ch, horms@...nel.org
Subject: Re: [PATCH net-next] net: restore napi_consume_skb()'s NULL-handling

On Wed, Nov 26, 2025 at 5:43 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Commit e20dfbad8aab ("net: fix napi_consume_skb() with alien skbs")
> added a skb->cpu check to napi_consume_skb(), before the point where
> napi_consume_skb() validated skb is not NULL.
>
> Add an explicit check to the early exit condition.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>