netdev - Re: [PATCH net-next 3/3] net: thunderbolt: Allow reading link settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ac72bf4-aa0e-4e3f-b6ef-4ed2dce923e1@lunn.ch>
Date: Thu, 27 Nov 2025 20:20:53 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc: netdev@...r.kernel.org, Yehezkel Bernat <YehezkelShB@...il.com>,
	Ian MacDonald <ian@...statz.com>,
	Salvatore Bonaccorso <carnil@...ian.org>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 3/3] net: thunderbolt: Allow reading link
 settings

> +static int tbnet_get_link_ksettings(struct net_device *dev,
> +				    struct ethtool_link_ksettings *cmd)
> +{
> +	const struct tbnet *net = netdev_priv(dev);
> +	const struct tb_xdomain *xd = net->xd;
> +	int speed;
> +
> +	ethtool_link_ksettings_zero_link_mode(cmd, supported);
> +	ethtool_link_ksettings_zero_link_mode(cmd, advertising);
> +
> +	/* Figure out the current link speed and width */
> +	switch (xd->link_speed) {
> +	case 40:
> +		/* For Gen 4 80G symmetric link the closest one
> +		 * available is 56G so we report that.
> +		 */
> +		ethtool_link_ksettings_add_link_mode(cmd, supported,
> +						     56000baseKR4_Full);
> +		ethtool_link_ksettings_add_link_mode(cmd, advertising,
> +						     56000baseKR4_Full);
> +		speed = SPEED_56000;

Please add SPEED_80000.

I commented on the previous version. Is supported and advertising
actually needed? If not, please leave them blank.

	Andrew