netdev - Re: [PATCH net-next v16 3/5] eea: probe the netdevice and create adminq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251126164242.2b649c98@kernel.org>
Date: Wed, 26 Nov 2025 16:42:42 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Wen Gu <guwen@...ux.alibaba.com>, Philo Lu
 <lulie@...ux.alibaba.com>, Lorenzo Bianconi <lorenzo@...nel.org>, Vadim
 Fedorenko <vadim.fedorenko@...ux.dev>, Dong Yibo <dong100@...se.com>, Lukas
 Bulwahn <lukas.bulwahn@...hat.com>, Geert Uytterhoeven
 <geert+renesas@...der.be>, Vivian Wang <wangruikang@...as.ac.cn>, MD Danish
 Anwar <danishanwar@...com>, Dust Li <dust.li@...ux.alibaba.com>
Subject: Re: [PATCH net-next v16 3/5] eea: probe the netdevice and create
 adminq

On Mon, 24 Nov 2025 09:42:49 +0800 Xuan Zhuo wrote:
> +struct eea_aq_dev_status *eea_adminq_dev_status(struct eea_net *enet)
> +{
> +	struct eea_aq_queue_drv_status *drv_status;
> +	struct eea_aq_dev_status *dev_status;
> +	struct eea_ring *ering;
> +	int err, i, num, size;
> +	void *rep, *req;
> +
> +	num = enet->cfg.tx_ring_num * 2 + 1;
> +
> +	req = kcalloc(num, sizeof(struct eea_aq_queue_drv_status), GFP_KERNEL);
...
> +	drv_status = req;
> +	for (i = 0; i < enet->cfg.rx_ring_num * 2; ++i, ++drv_status) {

is the rx vs tx ring_num discrepancy here intentional ?