netdev - Re: [PATCH net-next V4 08/14] devlink: Allow rate node parents from other devlinks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <020f1f6fb31320f963b308ed333918756dba0d42.camel@nvidia.com>
Date: Fri, 28 Nov 2025 09:57:07 +0000
From: Cosmin Ratiu <cratiu@...dia.com>
To: Tariq Toukan <tariqt@...dia.com>, "kuba@...nel.org" <kuba@...nel.org>
CC: "corbet@....net" <corbet@....net>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "donald.hunter@...il.com" <donald.hunter@...il.com>,
	"davem@...emloft.net" <davem@...emloft.net>, "leon@...nel.org"
	<leon@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, "jiri@...nulli.us"
	<jiri@...nulli.us>, "pabeni@...hat.com" <pabeni@...hat.com>, Jiri Pirko
	<jiri@...dia.com>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Carolina Jubran <cjubran@...dia.com>, Mark Bloch <mbloch@...dia.com>,
	"rdunlap@...radead.org" <rdunlap@...radead.org>, Saeed Mahameed
	<saeedm@...dia.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Gal
 Pressman <gal@...dia.com>, Moshe Shemesh <moshe@...dia.com>
Subject: Re: [PATCH net-next V4 08/14] devlink: Allow rate node parents from
 other devlinks

On Thu, 2025-11-27 at 20:09 -0800, Jakub Kicinski wrote:
> On Tue, 25 Nov 2025 22:06:07 +0200 Tariq Toukan wrote:
> > @@ -646,6 +706,13 @@ int devlink_nl_rate_set_doit(struct sk_buff
> > *skb, struct genl_info *info)
> >  		goto unlock;
> >  	}
> >  
> > +	if (info->user_ptr[1] && info->user_ptr[1] != devlink &&
> > +	    !ops->supported_cross_device_rate_nodes) {
> > +		NL_SET_ERR_MSG(info->extack,
> > +			       "Cross-device rate parents aren't
> > supported");
> > +		return -EOPNOTSUPP;
> 
> err = ...
> goto unlock

Nice catch. Will fix.

Cosmin.