netdev - Re: [PATCH net-next v19 00/15] net: phy: Introduce PHY ports representation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4910c9a6-0586-474c-b2e2-4c599e44272f@meta.com>
Date: Fri, 28 Nov 2025 08:06:12 -0500
From: Chris Mason <clm@...a.com>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>,
        Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, thomas.petazzoni@...tlin.com,
        Andrew Lunn <andrew@...n.ch>, Eric Dumazet <edumazet@...gle.com>,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Herve Codina <herve.codina@...tlin.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Köry Maincent <kory.maincent@...tlin.com>,
        Marek Behún <kabel@...nel.org>,
        Oleksij Rempel <o.rempel@...gutronix.de>,
        Nicolò Veronese <nicveronese@...il.com>,
        Simon Horman <horms@...nel.org>, mwojtas@...omium.org,
        Antoine Tenart <atenart@...nel.org>, devicetree@...r.kernel.org,
        Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski
 <krzk+dt@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Romain Gantois <romain.gantois@...tlin.com>,
        Daniel Golle <daniel@...rotopia.org>,
        Dimitri Fedrau <dimitri.fedrau@...bherr.com>,
        Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH net-next v19 00/15] net: phy: Introduce PHY ports
 representation

On 11/27/25 10:53 AM, Maxime Chevallier wrote:
> Hi Chris,
> 
> On 27/11/2025 04:00, Jakub Kicinski wrote:
>> On Sat, 22 Nov 2025 13:42:59 +0100 Maxime Chevallier wrote:
>>> This is v19 of the phy_port work. Patches 2 and 3 lack PHY maintainers reviews.
>>>
>>> This v19 has no changes compared to v18, but patch 2 was rebased on top
>>> of the recent 1.6T linkmodes.
>>>
>>> Thanks for everyone's patience and reviews on that work ! Now, the
>>> usual blurb for the series description.
>>
>> Hopefully we can still make v6.19, but we hooked up Claude Code review
>> to patchwork this week, and it points out some legit issues here :(
>> Some look transient but others are definitely legit, please look thru
>> this:
>>

[ ... urls mangled by meta email ... ]

> I was told by Paolo to reach out with any feedback on the LLM reviews :
>

Thanks for sending these along, it really helps me fix up the prompts.

[ ... ]

> 
> Does priv->line_interface need to be reset when enable is false? The
> old mv2222_sfp_remove() explicitly set it to PHY_INTERFACE_MODE_NA,
> but the new code leaves it at whatever value was set during the last
> module insertion. Functions like mv2222_config_aneg() check whether
> priv->line_interface equals PHY_INTERFACE_MODE_NA to determine if a
> module is present.
> 
> --------x8----------------------------------------------------------------------
> 
> 
> Looking at the call-sites, we can see that when the .configure_mii port ops is
> called with enabled = false, the interface is always PHY_INTERFACE_MODE_NA.
> 
> Looks like the potential problem was identified correctly, but it failed to see
> that this can't ever happen.

This is also a problem for bpf reviews, where claude finds a pretty
detailed path to a bug that can never happen in practice.  I'll use this
and a few similar false positive reports to try and improve the
elimination of impossible bugs.

> It's a bit tricky I guess, as the call-site in question
> is introduced by a previous patch in the same series though.

This part shouldn't be a factor (I hope), but I'll check.

-chris