netdev - Re: [can-next] can: Kconfig: select CAN driver infrastructure by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251128-terrestrial-gainful-goose-0723b2-mkl@pengutronix.de>
Date: Fri, 28 Nov 2025 15:43:20 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Oliver Hartkopp <socketcan@...tkopp.net>
Cc: linux-can@...r.kernel.org, netdev@...r.kernel.org, davem@...emloft.net, 
	kuba@...nel.org, kernel@...gutronix.de, Vincent Mailhol <mailhol@...nel.org>
Subject: Re: [can-next] can: Kconfig: select CAN driver infrastructure by
 default

On 28.11.2025 11:08:03, Oliver Hartkopp wrote:
> The CAN bus support enabled with CONFIG_CAN provides a socket-based
> access to CAN interfaces. With the introduction of the latest CAN protocol
> CAN XL additional configuration status information needs to be exposed to
> the network layer than formerly provided by standard Linux network drivers.
>
> This requires the CAN driver infrastructure to be selected by default.
> As the CAN network layer can only operate on CAN interfaces anyway all
> distributions and common default configs enable at least one CAN driver.
>
> So selecting CONFIG_CAN_DEV when CONFIG_CAN is selected by the user has
> no effect on established configurations but solves potential build issues
> when CONFIG_CAN[_XXX]=y is set together with CANFIG_CAN_DEV=m
>
> Fixes: 1a620a723853 ("can: raw: instantly reject unsupported CAN frames")
> Reported-by: Vincent Mailhol <mailhol@...nel.org>
> Suggested-by: Marc Kleine-Budde <mkl@...gutronix.de>
> Signed-off-by: Oliver Hartkopp <socketcan@...tkopp.net>

I think we take this, at least for now. But I'll remove my Suggested-by,
which was a leftover from v3.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |