netdev - Re: [PATCH] ipv4: Fix log message for martian source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aSnSJZpC8ddH7ZN0@c83cfd0f4f41d48a>
Date: Fri, 28 Nov 2025 17:47:33 +0100
From: Clara Engler <cve@....cx>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	davem@...emloft.net, dsahern@...nel.org, edumazet@...gle.com,
	pabeni@...hat.com, horms@...nel.org
Subject: Re: [PATCH] ipv4: Fix log message for martian source

On Thu, Nov 27, 2025 at 06:17:43PM -0800, Jakub Kicinski wrote:
> imagine there was another comma in this print:
> 
> 	martian source, %pI4 from %pI4, on dev %s
> 
> we should leave it as is, I think.

Yes, this comma indeed makes it more helpful.

Personally, my preference would lie in a format such as the following:

    martian source (src={SRC}, dst={DST}, dev={DEV}

with a respective similar change to the martian destination.

> People may be grepping logs for this exact format..

I agree with you partially.  For such a trivial change, it is probably
not worth to pursue this any further, but I don't think "log stability"
is something to aim for/guarantee.

Thank You
Clara