netdev - Re: [PATCH net-next v8 1/1] Documentation: net: add flow control guide and document ethtool API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251128103259.258f6fa5@kernel.org>
Date: Fri, 28 Nov 2025 10:32:59 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "Russell King (Oracle)" <linux@...linux.org.uk>, Andrew Lunn
 <andrew@...n.ch>, Vladimir Oltean <vladimir.oltean@....com>, Alexei
 Starovoitov <ast@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Rob
 Herring <robh@...nel.org>, Florian Fainelli <f.fainelli@...il.com>, Donald
 Hunter <donald.hunter@...il.com>, Daniel Borkmann <daniel@...earbox.net>,
 Jonathan Corbet <corbet@....net>, John Fastabend
 <john.fastabend@...il.com>, Lukasz Majewski <lukma@...x.de>, Maxime
 Chevallier <maxime.chevallier@...tlin.com>, Stanislav Fomichev
 <sdf@...ichev.me>, Paolo Abeni <pabeni@...hat.com>, Jiri Pirko
 <jiri@...nulli.us>, Jesper Dangaard Brouer <hawk@...nel.org>,
 Divya.Koppera@...rochip.com, Kory Maincent <kory.maincent@...tlin.com>,
 Vadim Fedorenko <vadim.fedorenko@...ux.dev>, netdev@...r.kernel.org,
 Sabrina Dubroca <sd@...asysnail.net>, linux-kernel@...r.kernel.org,
 kernel@...gutronix.de, Krzysztof Kozlowski <krzk+dt@...nel.org>, "David S.
 Miller" <davem@...emloft.net>, Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH net-next v8 1/1] Documentation: net: add flow control
 guide and document ethtool API

On Fri, 28 Nov 2025 09:55:22 +0100 Oleksij Rempel wrote:
>  * **Constraint Checking:**
>  *   Drivers MUST accept a setting of @autoneg (true) even if generic
>  *   link autonegotiation ('ethtool -s / --change') is currently disabled.
>  *   This allows the user to pre-configure the desired policy for future
>  *   link modes.

!? I pointed out so many times that this contradicts the long standing
recommendation.

Can you please tell me what is preventing us from deprecating pauseparam
API *for autoneg* and using linkmodes which are completely unambiguous.
And allows the user to "pre configure" the advertisement.

The pause set API should remain primarily for forced mode configuration.
Perhaps the move is to make it read only for new drivers when aneg is
turned on?