netdev - Re: [PATCH net 2/3] bonding: restructure ad_churn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSjsJxaB5LmHYM3d@fedora>
Date: Fri, 28 Nov 2025 00:26:15 +0000
From: Hangbin Liu <liuhangbin@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, Jay Vosburgh <jv@...sburgh.net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>,
	Mahesh Bandewar <maheshb@...gle.com>, Shuah Khan <shuah@...nel.org>,
	linux-kselftest@...r.kernel.org, Liang Li <liali@...hat.com>
Subject: Re: [PATCH net 2/3] bonding: restructure ad_churn_machine

On Thu, Nov 27, 2025 at 04:29:47PM +0100, Paolo Abeni wrote:
> >> Please avoid white-space changes only, or if you are going to target
> >> net-next, move them to a pre-req patch.
> > 
> > OK, what's pre-req patch?
> 
> I mean: a separate patch, earlier in the series, to keep cosmetic and
> functional changes separated and more easily reviewable.

Sure

> >>> +		if (actor_synced) {
> >>> +			port->sm_vars &= ~AD_PORT_ACTOR_CHURN;
> >>>  			port->sm_churn_actor_state = AD_NO_CHURN;
> >>> -		} else {
> >>> -			port->churn_actor_count++;
> >>> -			port->sm_churn_actor_state = AD_CHURN;
> >>> +			actor_churned = false;
> >>>  		}
> >>
> >> I think this part is not described by the state diagram above?!?
> > 
> > This part is about path (3), port in monitor or churn, and actor is in sync.
> > Then move to state no_churn.
> > 
> > Do you mean port->sm_vars &= ~AD_PORT_ACTOR_CHURN is not described?
> > Hmm, maybe we don't need this after re-organise.
> 
> I mean the state change in the else part, I can't map them in the state
> machine diagram.

The "else" line is removed

Thanks
Hangbin