[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAPpSM+S1-c68WsY3KYQp4R3kC+p+eREdJP0Qas9Q68MiA9Y3AA@mail.gmail.com>
Date: Thu, 27 Nov 2025 17:16:18 -0700
From: Xiang Mei <xmei5@....edu>
To: Jakub Kicinski <kuba@...nel.org>
Cc: security@...nel.org, netdev@...r.kernel.org, toke@...e.dk,
xiyou.wangcong@...il.com, cake@...ts.bufferbloat.net, bestswngs@...il.com
Subject: Re: [PATCH net v7 1/2] net/sched: sch_cake: Fix incorrect qlen
reduction in cake_drop
Thanks for the reminder. The conflict has been resolved in v8.
On Thu, Nov 27, 2025 at 4:36 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 26 Nov 2025 12:45:12 -0700 Xiang Mei wrote:
> > In cake_drop(), qdisc_tree_reduce_backlog() is used to update the qlen
> > and backlog of the qdisc hierarchy. Its caller, cake_enqueue(), assumes
> > that the parent qdisc will enqueue the current packet. However, this
> > assumption breaks when cake_enqueue() returns NET_XMIT_CN: the parent
> > qdisc stops enqueuing current packet, leaving the tree qlen/backlog
> > accounting inconsistent. This mismatch can lead to a NULL dereference
> > (e.g., when the parent Qdisc is qfq_qdisc).
>
> This series does not apply, please rebase on netdev/net/main.
> --
> pw-bot: cr
Powered by blists - more mailing lists