netdev - Re: [PATCH 5/7] iplink_can: add initial CAN XL support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc2c8f97-b481-4c77-99ba-5d3df7c74644@kernel.org>
Date: Sun, 30 Nov 2025 00:13:53 +0100
From: Vincent Mailhol <mailhol@...nel.org>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: netdev@...r.kernel.org, Marc Kleine-Budde <mkl@...gutronix.de>,
 Oliver Hartkopp <socketcan@...tkopp.net>, David Ahern <dsahern@...nel.org>,
 linux-kernel@...r.kernel.org, linux-can@...r.kernel.org
Subject: Re: [PATCH 5/7] iplink_can: add initial CAN XL support

On 29/11/2025 at 18:04, Stephen Hemminger wrote:
> On Sat, 29 Nov 2025 16:29:10 +0100
> Vincent Mailhol <mailhol@...nel.org> wrote:
> 
>> +		} else if (matches(*argv, "xl") == 0) {
>> +			NEXT_ARG();
>> +			set_ctrlmode("xl", *argv, &cm, CAN_CTRLMODE_XL);
>> +		} else if (matches(*argv, "xbitrate") == 0) {
>> +			NEXT_ARG();
>> +			if (get_u32(&xl_dbt.bitrate, *argv, 0))
>> +				invarg("invalid \"xbitrate\" value", *argv);
>> +		} else if (matches(*argv, "xsample-point") == 0) {
>> +			float sp;
>> +
>> +			NEXT_ARG();
>> +			if (get_float(&sp, *argv))
>> +				invarg("invalid \"xsample-point\" value", *argv);
>> +			xl_dbt.sample_point = (__u32)(sp * 1000);
>> +		} else if (matches(*argv, "xtq") == 0) {
>> +			NEXT_ARG();
>> +			if (get_u32(&xl_dbt.tq, *argv, 0))
>> +				invarg("invalid \"xtq\" value", *argv);
>> +		} else if (matches(*argv, "xprop-seg") == 0) {
>> +			NEXT_ARG();
>> +			if (get_u32(&xl_dbt.prop_seg, *argv, 0))
>> +				invarg("invalid \"xprop-seg\" value", *argv);
>> +		} else if (matches(*argv, "xphase-seg1") == 0) {
>> +			NEXT_ARG();
>> +			if (get_u32(&xl_dbt.phase_seg1, *argv, 0))
>> +				invarg("invalid \"xphase-seg1\" value", *argv);
>> +		} else if (matches(*argv, "xphase-seg2") == 0) {
>> +			NEXT_ARG();
>> +			if (get_u32(&xl_dbt.phase_seg2, *argv, 0))
>> +				invarg("invalid \"xphase-seg2\" value", *argv);
>> +		} else if (matches(*argv, "xsjw") == 0) {
>> +			NEXT_ARG();
>> +			if (get_u32(&xl_dbt.sjw, *argv, 0))
>> +				invarg("invalid \"xsjw\" value", *argv);
>> +		} else if (matches(*argv, "xtdcv") == 0) {
>> +			NEXT_ARG();
>> +			if (get_u32(&xl.tdcv, *argv, 0))
>> +				invarg("invalid \"xtdcv\" value", *argv);
>> +		} else if (matches(*argv, "xtdco") == 0) {
>> +			NEXT_ARG();
>> +			if (get_u32(&xl.tdco, *argv, 0))
>> +				invarg("invalid \"xtdco\" value", *argv);
>> +		} else if (matches(*argv, "xtdcf") == 0) {
>> +			NEXT_ARG();
>> +			if (get_u32(&xl.tdcf, *argv, 0))
>> +				invarg("invalid \"xtdcf\" value", *argv);
>>  		} else if (matches(*argv, "loopback") == 0) {
>>  			NEXT_ARG();
> 
> not accepting any new code with matches()

Ack. I will do a s/matches/strcmp/g in the next version.

For the old code, I assume that we should keep it as-is, otherwise that would be
a breaking change.


Yours sincerely,
Vincent Mailhol