netdev - Re: [PATCH net] net: netpoll: initialize work queue before error checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <176439061855.907626.14454545998670880238.git-patchwork-notify@kernel.org>
Date: Sat, 29 Nov 2025 04:30:18 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Breno Leitao <leitao@...ian.org>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, horms@...nel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, gustavold@...il.com, asantostc@...il.com,
 kernel-team@...a.com
Subject: Re: [PATCH net] net: netpoll: initialize work queue before error
 checks

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu, 27 Nov 2025 07:30:15 -0800 you wrote:
> Prevent a kernel warning when netconsole setup fails on devices with
> IFF_DISABLE_NETPOLL flag. The warning (at kernel/workqueue.c:4242 in
> __flush_work) occurs because the cleanup path tries to cancel an
> uninitialized work queue.
> 
> When __netpoll_setup() encounters a device with IFF_DISABLE_NETPOLL,
> it fails early and calls skb_pool_flush() for cleanup. This function
> calls cancel_work_sync(&np->refill_wq), but refill_wq hasn't been
> initialized yet, triggering the warning.
> 
> [...]

Here is the summary with links:
  - [net] net: netpoll: initialize work queue before error checks
    https://git.kernel.org/netdev/net/c/e5235eb6cfe0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html