netdev - Re: [PATCH] selftests: tls: fix read/write of garbage value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aSrJTmtJqOX0rNDh@krikkit>
Date: Sat, 29 Nov 2025 11:22:06 +0100
From: Sabrina Dubroca <sd@...asysnail.net>
To: Ankit Khushwaha <ankitkhushwaha.linux@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, Shuah Khan <shuah@...nel.org>,
	netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests: tls: fix read/write of garbage value

2025-11-29, 12:07:26 +0530, Ankit Khushwaha wrote:
> In 'poll_partial_rec_async' a uninitialized char variable 'token' with
> *garbage* value is used for write/read instruction to synchronize
> between threads via a pipe.
> 
> tls.c:2833:26: warning: variable 'token' is uninitialized
>       when passed as a const pointer argument here
>       [-Wuninitialized-const-pointer]
>  2833 |            EXPECT_EQ(write(p[1], &token, 1), 1); /* Barrier #1 */
> 
> Initialize 'token' to '\0' to prevent write/read of garbage value.

I'm not opposed to making the compiler happy, but in this case
"garbage" is completely fine, we don't care about the value.

So I think the subject and the commit message should talk about
"silencing a compiler warning" rather than "fixing use of garbage
value".

And your patch should indicate the target tree in the subject (here,
with [PATCH net-next]), see
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html

-- 
Sabrina