netdev - Re: [PATCH net-next v2 2/4] net/sched: sch_cake: Add cake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <willemdebruijn.kernel.2e44851dd8b26@gmail.com>
Date: Fri, 28 Nov 2025 21:08:13 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Toke Høiland-Jørgensen <toke@...hat.com>, 
 Toke Høiland-Jørgensen <toke@...e.dk>, 
 Jamal Hadi Salim <jhs@...atatu.com>, 
 Cong Wang <xiyou.wangcong@...il.com>, 
 Jiri Pirko <jiri@...nulli.us>, 
 "David S. Miller" <davem@...emloft.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Simon Horman <horms@...nel.org>
Cc: Jonas Köppeler <j.koeppeler@...berlin.de>, 
 cake@...ts.bufferbloat.net, 
 netdev@...r.kernel.org, 
 Toke Høiland-Jørgensen <toke@...hat.com>
Subject: Re: [PATCH net-next v2 2/4] net/sched: sch_cake: Add cake_mq qdisc
 for using cake on mq devices

Toke Høiland-Jørgensen wrote:
> Add a cake_mq qdisc which installs cake instances on each hardware
> queue on a multi-queue device.
> 
> This is just a copy of sch_mq that installs cake instead of the default
> qdisc on each queue. Subsequent commits will add sharing of the config
> between cake instances, as well as a multi-queue aware shaper algorithm.
> 
> Reviewed-by: Jamal Hadi Salim <jhs@...atatu.com>
> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
> ---
>  net/sched/sch_cake.c | 214 ++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 213 insertions(+), 1 deletion(-)

Is this code duplication unavoidable?

Could the same be achieved by either

extending the original sch_mq to have a variant that calls the
custom cake_mq_change.

Or avoid hanging the shared state off of parent mq entirely. Have the
cake instances share it directly. E.g., where all but the instance on
netdev_get_tx_queue(dev, 0) are opened in a special "shared" mode (a
bit like SO_REUSEPORT sockets) and lookup the state from that
instance.