netdev - Re: [PATCH 4/7] iplink_can: add the "restricted" option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251129090320.594aa81a@phoenix.local>
Date: Sat, 29 Nov 2025 09:03:20 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Vincent Mailhol <mailhol@...nel.org>
Cc: netdev@...r.kernel.org, Marc Kleine-Budde <mkl@...gutronix.de>, Oliver
 Hartkopp <socketcan@...tkopp.net>, David Ahern <dsahern@...nel.org>,
 linux-kernel@...r.kernel.org, linux-can@...r.kernel.org
Subject: Re: [PATCH 4/7] iplink_can: add the "restricted" option

On Sat, 29 Nov 2025 16:29:09 +0100
Vincent Mailhol <mailhol@...nel.org> wrote:

> @@ -257,6 +259,9 @@ static int can_parse_opt(struct link_util *lu, int argc, char **argv,
>  				invarg("\"tdc-mode\" must be either of \"auto\", \"manual\" or \"off\"",
>  					*argv);
>  			}
> +		} else if (matches(*argv, "restricted") == 0) {
> +			NEXT_ARG();
> +			set_ctrlmode("restricted", *argv, &cm, CAN_CTRLMODE_RESTRICTED);
>  		} else if (matches(*argv, "restart") == 0) {
>  			__u32 val = 1;

Good example of iproute2 has banned use of matches. Because usage like the
(think of what happens when user was previously using 'r')