netdev - Re: [PATCH net-next v3 1/2] net: phy: phy-c45: add SQI and SQI+ support for OATC14 10Base-T1S PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe02fb6f-b9f9-4fb1-ba63-893ae18f0376@microchip.com>
Date: Sun, 30 Nov 2025 09:13:50 +0000
From: <Parthiban.Veerasooran@...rochip.com>
To: <kuba@...nel.org>
CC: <piergiorgio.beruto@...il.com>, <andrew@...n.ch>, <hkallweit1@...il.com>,
	<linux@...linux.org.uk>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v3 1/2] net: phy: phy-c45: add SQI and SQI+
 support for OATC14 10Base-T1S PHYs

Hi Jakub,

Thank you for reviewing the patch.

On 28/11/25 8:14 am, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Wed, 26 Nov 2025 16:19:54 +0530 Parthiban Veerasooran wrote:
>>   /**
>>    * struct phy_device - An instance of a PHY
>>    *
>> @@ -772,6 +796,8 @@ struct phy_device {
>>        /* MACsec management functions */
>>        const struct macsec_ops *macsec_ops;
>>   #endif
>> +
>> +     struct phy_oatc14_sqi_capability oatc14_sqi_capability;
> 
> kdoc sayeth:
> 
> include/linux/phy.h:800 struct member 'oatc14_sqi_capability' not described in 'phy_device'
Thanks for catching this. Somehow missed my radar. I will add the 
description for the struct member 'oatc14_sqi_capability' in the next 
version.

Best regards,
Parthiban V
> --
> pw-bot: cr