netdev - Re: [PATCH net-next 08/15] net: dsa: realtek: use simple HSR offload helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD++jLmSbkLURKLxDHJ+5NWmQZ04eN-vaDyEst_VE=ZL4b_YYg@mail.gmail.com>
Date: Sun, 30 Nov 2025 17:03:38 +0100
From: Linus Walleij <linusw@...nel.org>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>, 
	Linus Walleij <linus.walleij@...aro.org>, Alvin Šipraga <alsi@...g-olufsen.dk>
Subject: Re: [PATCH net-next 08/15] net: dsa: realtek: use simple HSR offload helpers

On Sun, Nov 30, 2025 at 2:17 PM Vladimir Oltean <vladimir.oltean@....com> wrote:

> All known Realtek protocols: "rtl4a", "rtl8_4" and "rtl8_4t" use
> dsa_xmit_port_mask(), so they are compatible with accelerating TX packet
> duplication for HSR rings.
>
> Enable that feature by setting the port_hsr_join() and port_hsr_leave()
> operations to the simple helpers provided by DSA.
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: "Alvin Šipraga" <alsi@...g-olufsen.dk>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

This looks correct and I also like where you're going with this!
Reviewed-by: Linus Walleij <linusw@...nel.org>

Yours,
Linus Walleij