netdev - Re: [PATCH net-next 3/3] net: thunderbolt: Allow reading link settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251201061922.GC2580184@black.igk.intel.com>
Date: Mon, 1 Dec 2025 07:19:22 +0100
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, Yehezkel Bernat <YehezkelShB@...il.com>,
	Ian MacDonald <ian@...statz.com>,
	Salvatore Bonaccorso <carnil@...ian.org>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 3/3] net: thunderbolt: Allow reading link
 settings

On Fri, Nov 28, 2025 at 03:57:07PM +0100, Andrew Lunn wrote:
> > > Please add SPEED_80000.
> > 
> > Sure. One additional question though. Comment on top of SPEED_ definitions
> > suggest changing __get_link_speed() of the bonding driver accordingly but
> > it basically converts from SPEED_ to AD_LINK_SPEED_ which I think we need
> > to add too. However, these are user-facing values so should I add the
> > AD_LINK_SPEED_80000 entry to the end of that enum to avoid any possible
> > breakage?
> 
> Are they user facing? They should be define in include/uapi if they
> were. I would keep the list sorted, and Cc: the bonding driver
> Maintainer, Jay Vosburgh <jv@...sburgh.net> (maintainer:BONDING DRIVER).

Indeed, they look like they are not. As you pointed out these are internals
of the drivers/net/bonding/bond_3ad.c and not exposed as is to the
userspace.

I'll add the 80G there for both of these in v2 and Cd Jay just in case.
Since merge window is open I'll send v2 after v6.19-rc1 is released.