netdev - Re: [PATCH] r8169: fix RTL8117 Wake-on-Lan in DASH mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251202.164738.1343792086968703812.rene@exactco.de>
Date: Tue, 02 Dec 2025 16:47:38 +0100 (CET)
From: René Rebe <rene@...ctco.de>
To: andrew@...n.ch
Cc: netdev@...r.kernel.org, hkallweit1@...il.com, nic_swsd@...ltek.com
Subject: Re: [PATCH] r8169: fix RTL8117 Wake-on-Lan in DASH mode

Hi,

On Tue, 2 Dec 2025 16:41:49 +0100, Andrew Lunn <andrew@...n.ch> wrote:

> > While at it, enable wake on magic packet by default, like most other
> > Linux drivers do.
> 
> Please give examples, because i think that is false.
> 
> You should have the option to enable any WoL mode the hardware
> supports, but none should be enabled by default.

All my other 42 computer systems in the company come up with WoL g
enabled. Here is an Intel example:

root@...0x:/srv/upstream/linux# ethtool -i eth0
driver: igc
version: 6.17.9-t2
firmware-version: 1068:8754
expansion-rom-version:
bus-info: 0000:0c:00.0
supports-statistics: yes
supports-test: yes
supports-eeprom-access: yes
supports-register-dump: yes
supports-priv-flags: yes

# ethtool  eth0 | grep wake -i
        Supports Wake-on: pumbg
        Wake-on: g

You could git grep the linux kernel for more data.

> > There is still another issue that should be fixed: the dirver init
> > kills the OOB BMC connection until if up, too. We also should probaly
> > not even conditionalize rtl8168_driver_stop on wol_enabled as the BMC
> > should always be accessible. IMHO even on module unload.
> 
> Is there any way to know there is a BMC connected?

In general that is what this dash mode in the driver is about.

-- 
René Rebe, ExactCODE GmbH, Berlin, Germany
https://exactco.de • https://t2linux.com • https://patreon.com/renerebe