netdev - Re: [PATCH v2] net: stmmac: Modify the judgment condition of "tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251202103614.6a185bf6@kernel.org>
Date: Tue, 2 Dec 2025 10:36:14 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: 2694439648@...com
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
 hailong.fan@...ngine.com, netdev@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, inux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: stmmac: Modify the judgment condition of
 "tx_avail" from 1 to 2

On Tue,  2 Dec 2025 15:43:59 +0800 2694439648@...com wrote:
> -	if (unlikely(stmmac_tx_avail(priv, queue) <= (MAX_SKB_FRAGS + 1))) {
> +	if (unlikely(stmmac_tx_avail(priv, queue) <= (MAX_SKB_FRAGS + 2))) {

Also, if there isn't a comment already somewhere - it's worth
documenting what the + 2 stands for. head buffer + vlan + frags ?