netdev - Re: [PATCH iproute2-next v2 5/7] iplink_can: add initial CAN XL interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251201163810.3246dc49@phoenix.local>
Date: Mon, 1 Dec 2025 16:38:10 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Vincent Mailhol <mailhol@...nel.org>
Cc: netdev@...r.kernel.org, Marc Kleine-Budde <mkl@...gutronix.de>, Oliver
 Hartkopp <socketcan@...tkopp.net>, David Ahern <dsahern@...nel.org>,
 Rakuram Eswaran <rakuram.e96@...il.com>, Stéphane Grosjean
 <stephane.grosjean@...e.fr>, linux-kernel@...r.kernel.org,
 linux-can@...r.kernel.org
Subject: Re: [PATCH iproute2-next v2 5/7] iplink_can: add initial CAN XL
 interface

On Mon, 01 Dec 2025 23:55:13 +0100
Vincent Mailhol <mailhol@...nel.org> wrote:

>  
> -static void can_print_tdc_opt(struct rtattr *tdc_attr)
> +static void can_print_tdc_opt(struct rtattr *tdc_attr, bool is_xl)
>  {
>  	struct rtattr *tb[IFLA_CAN_TDC_MAX + 1];
>  
>  	parse_rtattr_nested(tb, IFLA_CAN_TDC_MAX, tdc_attr);
>  	if (tb[IFLA_CAN_TDC_TDCV] || tb[IFLA_CAN_TDC_TDCO] ||
>  	    tb[IFLA_CAN_TDC_TDCF]) {
> -		open_json_object("tdc");
> +		const char *tdc = is_xl ? "xtdc" : "tdc";
> +
> +		open_json_object(tdc);
>  		can_print_nl_indent();
>  		if (tb[IFLA_CAN_TDC_TDCV]) {
> +			const char *tdcv_fmt = is_xl ? " xtdcv %u" : " tdcv %u";

Having a format string as variable can break (future) format checking and some compiler flags.