netdev - Re: [PATCH 2/2 net-next] selftests: ipv6_icmp: add tests for ICMPv6 handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f4331ce-7ca1-4109-99b1-90e45d9026ef@redhat.com>
Date: Tue, 2 Dec 2025 10:39:07 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Fernando Fernandez Mancera <fmancera@...e.de>,
 David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org
Cc: linux-kselftest@...r.kernel.org, shuah@...nel.org, horms@...nel.org,
 kuba@...nel.org, edumazet@...gle.com, davem@...emloft.net
Subject: Re: [PATCH 2/2 net-next] selftests: ipv6_icmp: add tests for ICMPv6
 handling

On 12/1/25 9:58 AM, Fernando Fernandez Mancera wrote:
> On 11/29/25 4:56 PM, David Ahern wrote:
>> On 11/26/25 12:19 PM, Fernando Fernandez Mancera wrote:
>>> Test ICMPv6 to link local address and local address. In addition, this
>>> test set could be extended to cover more situations in the future.
>>>
>>> ICMPv6 to local addresses
>>>      TEST: Ping to link local address                                   [OK]
>>>      TEST: Ping to link local address from ::1                          [OK]
>>>      TEST: Ping to local address                                        [OK]
>>>      TEST: Ping to local address from ::1                               [OK]
>>>
>>
>> VRF based tests are needed as well to ensure this change works properly
>> with VRFs.
> 
> Thank you David. I am reposting it with VRF based tests once net-next 
> tree is open again.

While at it, please have a look at the shellcheck reported issues:

https://netdev-ctrl.bots.linux.dev/logs/build/1028021/14331024/shellcheck/stderr

Also, not a big deal but you could possibly simplify a bit the `ip addr`
parse code using json formatting:

ip -j -6 addr show dev ${dev} | jq -r '.[].addr_info[].local'


Cheers,

Paolo