netdev - Re: [PATCH v7 net-next 00/13] AccECN protocol case handling series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADVnQynFTrWf_waxGPH6VVPSZapSuxUb6LFdFUGj0NfiADAa7Q@mail.gmail.com>
Date: Wed, 3 Dec 2025 11:58:34 -0500
From: Neal Cardwell <ncardwell@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: chia-yu.chang@...ia-bell-labs.com, pabeni@...hat.com, edumazet@...gle.com, 
	parav@...dia.com, linux-doc@...r.kernel.org, corbet@....net, horms@...nel.org, 
	dsahern@...nel.org, kuniyu@...gle.com, bpf@...r.kernel.org, 
	netdev@...r.kernel.org, dave.taht@...il.com, jhs@...atatu.com, 
	stephen@...workplumber.org, xiyou.wangcong@...il.com, jiri@...nulli.us, 
	davem@...emloft.net, andrew+netdev@...n.ch, donald.hunter@...il.com, 
	ast@...erby.net, liuhangbin@...il.com, shuah@...nel.org, 
	linux-kselftest@...r.kernel.org, ij@...nel.org, 
	koen.de_schepper@...ia-bell-labs.com, g.white@...lelabs.com, 
	ingemar.s.johansson@...csson.com, mirja.kuehlewind@...csson.com, 
	cheshire@...le.com, rs.ietf@....at, Jason_Livingood@...cast.com, 
	vidhi_goel@...le.com
Subject: Re: [PATCH v7 net-next 00/13] AccECN protocol case handling series

On Mon, Dec 1, 2025 at 6:05 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon,  1 Dec 2025 17:37:47 +0100 chia-yu.chang@...ia-bell-labs.com
> wrote:
> > Plesae find the v7 AccECN case handling patch series, which covers
> > several excpetional case handling of Accurate ECN spec (RFC9768),
> > adds new identifiers to be used by CC modules, adds ecn_delta into
> > rate_sample, and keeps the ACE counter for computation, etc.
> >
> > This patch series is part of the full AccECN patch series, which is available at
> > https://github.com/L4STeam/linux-net-next/commits/upstream_l4steam/

Hi Chia-Yu,

My understanding is that you still have a set of packetdrill tests you
have been using to test this AccECN patch series. For the Linux
networking stack, the recent best practice for a significant patch
series like this is to add packetdrill tests to the
tools/testing/selftests/net/packetdrill/ directory as a separate
commit in the patch series.

For a recent example, see:

  selftest: packetdrill: Add max RTO test for SYN+ACK.
  https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=ffc56c90819e86d3a8c4eff6f831317d1c1476b6

When you next post the AccECN patch series for review, can you please
include a patch at the end of the series that posts your packetdrill
tests in the tools/testing/selftests/net/packetdrill/ directory? In
the commit description for that patch, please include a mention of the
packetdrill SHA1 you are using and a link to the packetdrill branch
you are using, somewhere on github or similar. Then I will look into
merging any packetdrill tool changes that you are depending on, if
there are packetdrill commits that you depend on that I have not
merged into packetdrill yet.

Thanks!
neal