netdev - Re: [PATCH net-next v13 11/12] virtio_net: Add support for TCP and UDP ethtool rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251204021540-mutt-send-email-mst@kernel.org>
Date: Thu, 4 Dec 2025 02:16:28 -0500
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Chris Mason <clm@...a.com>
Cc: Simon Horman <horms@...nel.org>, Daniel Jurgens <danielj@...dia.com>,
	netdev@...r.kernel.org, jasowang@...hat.com, pabeni@...hat.com,
	virtualization@...ts.linux.dev, parav@...dia.com,
	shshitrit@...dia.com, yohadt@...dia.com, xuanzhuo@...ux.alibaba.com,
	eperezma@...hat.com, jgg@...pe.ca, kevin.tian@...el.com,
	kuba@...nel.org, andrew+netdev@...n.ch, edumazet@...gle.com
Subject: Re: [PATCH net-next v13 11/12] virtio_net: Add support for TCP and
 UDP ethtool rules

On Wed, Dec 03, 2025 at 08:02:48AM -0800, Chris Mason wrote:
> On Wed, 3 Dec 2025 08:33:53 -0500 "Michael S. Tsirkin" <mst@...hat.com> wrote:
> 
> > On Tue, Dec 02, 2025 at 03:55:39PM +0000, Simon Horman wrote:
> > > On Wed, Nov 26, 2025 at 01:35:38PM -0600, Daniel Jurgens wrote:
> > > 
> > > ...
> > > 
> > > > @@ -6005,6 +6085,11 @@ static void parse_ip4(struct iphdr *mask, struct iphdr *key,
> > > >  		mask->tos = l3_mask->tos;
> > > >  		key->tos = l3_val->tos;
> > > >  	}
> > > > +
> > > > +	if (l3_mask->proto) {
> > > > +		mask->protocol = l3_mask->proto;
> > > > +		key->protocol = l3_val->proto;
> > > > +	}
> > > >  }
> > > 
> > > Hi Daniel,
> > > 
> > > Claude Code with review-prompts flags an issue here,
> > > which I can't convince myself is not the case.
> > > 
> > > If parse_ip4() is called for a IP_USER_FLOW, which use ethtool_usrip4_spec,
> > > as does this function, then all is well.
> > > 
> > > However, it seems that it may also be called for TCP_V4_FLOW and UDP_V4_FLOW
> > > flows, in which case accessing .proto will overrun the mask and key which
> > > are actually struct ethtool_tcpip4_spec.
> > > 
> > > https://netdev-ai.bots.linux.dev/ai-review.html?id=51d97b85-5ca3-4cb8-a96a-0d6eab5e7196#patch-10
> > 
> > 
> > Oh I didn't know about this one. Is there any data on how does it work?
> > Which model/prompt/etc?
> 
> I'm not actually sure if the netdev usage is written up somewhere?
> 
> The automation is running claude, but (hopefully) there's nothing specific to
> claude in the prompts, it's just what I've been developing against.
> 
> The prompts are:
> 
> https://github.com/masoncl/review-prompts
> 
> Jakub also wired up semcode indexing, which isn't required but does
> make it easier for claude to find code:
> 
> https://github.com/facebookexperimental/semcode
> 
> I'm still working on docs and easy setup for semcode and the review prompts,
> but please feel free to send questions.
> 
> -chris

Thanks, interesting! And the bot at https://netdev-ai.bots.linux.dev -
what does it review?  how do I find it's review of specific patches?