netdev - Re: [PATCH net-next 7/7] bnxt_en: Add PTP .getcrosststamp() interface to get device/host times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f8aca3d-192e-4471-8403-31c9811fa02e@intel.com>
Date: Wed, 3 Dec 2025 16:44:27 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Michael Chan
	<michael.chan@...adcom.com>, <davem@...emloft.net>
CC: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <andrew+netdev@...n.ch>, <pavan.chebbi@...adcom.com>,
	<andrew.gospodarek@...adcom.com>, Somnath Kotur <somnath.kotur@...adcom.com>
Subject: Re: [PATCH net-next 7/7] bnxt_en: Add PTP .getcrosststamp() interface
 to get device/host times



On 12/2/2025 2:21 PM, Vadim Fedorenko wrote:
> On 26/11/2025 21:56, Michael Chan wrote:
> 
> [...]
> 
>> +static int bnxt_ptp_getcrosststamp(struct ptp_clock_info *ptp_info,
>> +				   struct system_device_crosststamp *xtstamp)
>> +{
>> +	struct bnxt_ptp_cfg *ptp = container_of(ptp_info, struct bnxt_ptp_cfg,
>> +						ptp_info);
>> +
>> +	if (!(ptp->bp->fw_cap & BNXT_FW_CAP_PTP_PTM))
>> +		return -EOPNOTSUPP;
> 
> to have it enabled for x86-only (as the only supported platform as of
> now), additional check is needed:
> 
> if (pcie_ptm_enabled(ptp->bp->pdev) && boot_cpu_has(X86_FEATURE_ART))
> 	return -EOPNOTSUPP;
> 

Yep. This is the right way to check for the support, assuming its
standard PCIe PTM and not a custom implementation (as happened on a few
Intel LOMs in the past before standardization of PTM). You definitely
need to check for X86_FEATURE_ART since you're using the ART conversions.

Thanks,
Jake


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)