netdev - Re: [PATCH RFC net-next 00/15] net: stmmac: rk: cleanups galore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60b8ac3f-cad4-4aa7-bcf1-230f2067cc77@intel.com>
Date: Wed, 3 Dec 2025 16:51:59 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>, Andrew Lunn
	<andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>
CC: Alexandre Torgue <alexandre.torgue@...s.st.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Heiko Stuebner <heiko@...ech.de>, "Jakub
 Kicinski" <kuba@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-rockchip@...ts.infradead.org>,
	<linux-stm32@...md-mailman.stormreply.com>, Maxime Coquelin
	<mcoquelin.stm32@...il.com>, <netdev@...r.kernel.org>, Paolo Abeni
	<pabeni@...hat.com>
Subject: Re: [PATCH RFC net-next 00/15] net: stmmac: rk: cleanups galore



On 12/1/2025 8:44 AM, Russell King (Oracle) wrote:
> Again, I don't like this foo_enable() / foo_power_on() pattern with
> a true/false argument - when false, the function is not enabling
> nor "on"-ing, but disabling or "off"-ing. So, gmac_clk_enable() is
> going to get split up and renamed.
> 

Agreed, removing this anti-pattern is good. It makes the logic more
difficult to follow and understand than well named functions.


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)