netdev - Re: [Intel-wired-lan] [PATCH net v1] ice: stop counting UDP csum mismatch as rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6dcd835-7564-481a-a854-25b187893e6c@cloudflare.com>
Date: Fri, 5 Dec 2025 11:05:08 -0800
From: Jesse Brandeburg <jbrandeburg@...udflare.com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>,
 Jesse Brandeburg <jbrandeb@...nel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
 "Keller, Jacob E" <jacob.e.keller@...el.com>,
 IWL <intel-wired-lan@...ts.osuosl.org>,
 "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [Intel-wired-lan] [PATCH net v1] ice: stop counting UDP csum
 mismatch as rx_errors

On 12/5/25 12:26 AM, Loktionov, Aleksandr wrote:
>> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c
>> b/drivers/net/ethernet/intel/ice/ice_main.c
>> index 86f5859e88ef..d004acfa0f36 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_main.c
>> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
>> @@ -6995,7 +6995,6 @@ void ice_update_vsi_stats(struct ice_vsi *vsi)
>>   		cur_ns->rx_errors = pf->stats.crc_errors +
>>   				    pf->stats.illegal_bytes +
>>   				    pf->stats.rx_undersize +
>> -				    pf->hw_csum_rx_error +
> 
> Good day , Jesse
> It looks like you remove the single place where the ' hw_csum_rx_error' var is being really used.
> What about removing it's declaration and calculation then?

Hi Aleks! That's not true, however, as the stat is incremented in 
receive path and shown in ethtool -S. I think it is incredibly valuable 
to have in the ethtool stats that the hardware is "not offloading" a 
checksum. As well, all the other drivers in the high-speed Ethernet 
category have a similar counter.

I hope you'll agree it's still useful?