netdev - Re: [RFC] net: phy: air_en8811h: add Airoha AN8811HB support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251206084104.prufjf2jbvtwctlg@skbuf>
Date: Sat, 6 Dec 2025 10:41:04 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: Bjørn Mork <bjorn@...k.no>
Cc: netdev@...r.kernel.org, "Lucien.Jheng" <lucienzx159@...il.com>,
	Daniel Golle <daniel@...rotopia.org>
Subject: Re: [RFC] net: phy: air_en8811h: add Airoha AN8811HB support

On Thu, Dec 04, 2025 at 09:21:39AM +0100, Bjørn Mork wrote:
> >> -       pol = phy_get_rx_polarity(dev_fwnode(dev), phy_modes(phydev->interface),
> >> -                                 PHY_POL_NORMAL | PHY_POL_INVERT, default_pol);
> >> -       if (pol < 0)
> >> -               return pol;
> >> -       if (pol == PHY_POL_INVERT)
> >> -               pbus_value |= EN8811H_POLARITY_RX_REVERSE;
> >> +       return phy_get_rx_polarity(dev_fwnode(dev), phy_modes(phydev->interface),
> >> +                                  PHY_POL_NORMAL | PHY_POL_INVERT, default_pol)
> >> +               == PHY_POL_INVERT;

As I was writing a KUnit test for this API, I found another bug in my
submission which you also copied in yours, and I want to point it out
for when you resend.

The "supported" mask of polarities should be
	BIT(PHY_POL_NORMAL) | BIT(PHY_POL_INVERT)
rather than
	PHY_POL_NORMAL | PHY_POL_INVERT