netdev - Re: Please apply 5b1e38c0792cc7a44997328de37d393f81b2501a to 5.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aTTMcMFeq4Bt8wKk@laps>
Date: Sat, 6 Dec 2025 19:38:08 -0500
From: Sasha Levin <sashal@...nel.org>
To: Nathan Chancellor <nathan@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org,
	netdev@...r.kernel.org, Ioana Ciornei <ioana.ciornei@....com>
Subject: Re: Please apply 5b1e38c0792cc7a44997328de37d393f81b2501a to 5.15

On Wed, Dec 03, 2025 at 05:25:17PM -0700, Nathan Chancellor wrote:
>Hi stable folks,
>
>Please apply commit 5b1e38c0792c ("dpaa2-mac: bail if the dpmacs fwnode
>is not found") to 5.15, where it addresses an instance of
>-Wsometimes-uninitialized with clang-21 and newer, introduced by commit
>3264f599c1a8 ("net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver")
>in 5.14.
>
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:54:13: error: variable 'parent' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
>     54 |         } else if (is_acpi_node(fwnode)) {
>        |                    ^~~~~~~~~~~~~~~~~~~~
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:58:29: note: uninitialized use occurs here
>     58 |         fwnode_for_each_child_node(parent, child) {
>        |                                    ^~~~~~
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:54:9: note: remove the 'if' if its condition is always true
>     54 |         } else if (is_acpi_node(fwnode)) {
>        |                ^~~~~~~~~~~~~~~~~~~~~~~~~
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:43:39: note: initialize the variable 'parent' to silence this warning
>     43 |         struct fwnode_handle *fwnode, *parent, *child  = NULL;
>        |                                              ^
>        |                                               = NULL
>
>It applies and builds cleanly for me. If there are any issues, please
>let me know.

Queued up, thanks.

-- 
Thanks,
Sasha