netdev - Re: [PATCH net] tools: ynl: fix build on systems with old kernel headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c6b1c65-078d-4978-aadc-aae232274db1@fiberby.net>
Date: Mon, 8 Dec 2025 15:48:46 +0000
From: Asbjørn Sloth Tønnesen <ast@...erby.net>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 andrew+netdev@...n.ch, horms@...nel.org, donald.hunter@...il.com,
 Jason@...c4.com, davem@...emloft.net
Subject: Re: [PATCH net] tools: ynl: fix build on systems with old kernel
 headers

On 12/7/25 1:38 AM, Jakub Kicinski wrote:
> The wireguard YNL conversion was missing the customary .deps entry.
> NIPA doesn't catch this but my CentOS 9 system complains:
> 
>   wireguard-user.c:72:10: error: ‘WGALLOWEDIP_A_FLAGS’ undeclared here
>   wireguard-user.c:58:67: error: parameter 1 (‘value’) has incomplete type
>   58 | const char *wireguard_wgallowedip_flags_str(enum wgallowedip_flag value)
>      |                                             ~~~~~~~~~~~~~~~~~~~~~~^~~~~
> 
> And similarly does Ubuntu 22.04.
> 
> One extra complication here is that we renamed the header guard,
> so we need to compat with both old and new guard define.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> Found when syncing the "standalone" GitHub repo with ynl which
> has a CI building on Ubuntu.

Thank you for catching this.

I had put it in the sample commit, which was postponed last-minute.
Next time I will include it in same commit as the spec.

Reviewed-by: Asbjørn Sloth Tønnesen <ast@...erby.net>