netdev - Re: [PATCH net-next 2/3] dt-bindings: net: renesas-gbeth: Add port-id property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251209203406.GA1038446-robh@kernel.org>
Date: Tue, 9 Dec 2025 14:34:06 -0600
From: Rob Herring <robh@...nel.org>
To: John Madieu <john.madieu.xa@...renesas.com>
Cc: prabhakar.mahadev-lad.rj@...renesas.com, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, krzk+dt@...nel.org, conor+dt@...nel.org,
	geert+renesas@...der.be, biju.das.jz@...renesas.com,
	claudiu.beznea@...on.dev, linux@...linux.org.uk,
	magnus.damm@...il.com, mcoquelin.stm32@...il.com,
	alexandre.torgue@...s.st.com, netdev@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next 2/3] dt-bindings: net: renesas-gbeth: Add
 port-id property

On Thu, Dec 04, 2025 at 05:40:27PM +0100, John Madieu wrote:
> Add optional port-id property to identify ethernet ports on RZ/V2H
> SoCs. The hardware doesn't provide unique identification registers
> for multiple ethernet instances, so this property allows explicit
> port identification from the device tree.
> 
> Signed-off-by: John Madieu <john.madieu.xa@...renesas.com>
> ---
>  .../bindings/net/renesas,rzv2h-gbeth.yaml     | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/renesas,rzv2h-gbeth.yaml b/Documentation/devicetree/bindings/net/renesas,rzv2h-gbeth.yaml
> index bd53ab300f500..bb59c6a925d3f 100644
> --- a/Documentation/devicetree/bindings/net/renesas,rzv2h-gbeth.yaml
> +++ b/Documentation/devicetree/bindings/net/renesas,rzv2h-gbeth.yaml
> @@ -117,6 +117,23 @@ properties:
>            - description: AXI power-on system reset
>            - description: AHB reset
>  
> +  renesas,port-id:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Optional unique port identifier for this ethernet interface.
> +      Used for physical port identification (phys_port_id, phys_port_name).
> +      If not specified, the ethernet alias index is used as fallback.

We already have a common way with aliases, why do we want a vendor 
specific way?

> +    minimum: 0
> +    maximum: 255
> +
> +  renesas,port-name:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description:
> +      Optional custom name for the physical port. Used by
> +      ndo_get_phys_port_name() for interface naming.
> +      If not specified, "p<N>" format is used where N is the port-id
> +      or ethernet alias index.

Other vendors don't want to name their ports?

Maybe 'label' should be used here (for both parts? Generally, the value 
of label shouldn't be an ABI though. So if for example, software needs 
to find the 'mgmt' port then we should find another way to define that.

Rob