netdev - Re: [PATCH v6 1/2] net: mhi: Enable Ethernet interface support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a8e6a25a-24c6-4739-a9cc-0e0621f093ed@lunn.ch>
Date: Wed, 10 Dec 2025 17:50:14 +0100
From: Andrew Lunn <andrew@...n.ch>
To: vivek pernamitta <vivek.pernamitta@....qualcomm.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Manivannan Sadhasivam <mani@...nel.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, mhi@...ts.linux.dev,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v6 1/2] net: mhi: Enable Ethernet interface support

On Wed, Dec 10, 2025 at 10:46:11AM +0530, vivek pernamitta wrote:
> 
> On 12/9/2025 7:06 PM, Andrew Lunn wrote:
> 
>                 ndev = alloc_netdev(sizeof(struct mhi_net_dev), info->netname,
>         -                           NET_NAME_PREDICTABLE, mhi_net_setup);
>         +                           NET_NAME_PREDICTABLE, info->ethernet_if ?
>         +                           mhi_ethernet_setup : mhi_net_setup);
> 
>     Is the name predictable? I thought "eth%d" was considered
>     NET_NAME_ENUM?
> 
>     https://elixir.bootlin.com/linux/v6.18/source/net/ethernet/eth.c#L382
> 
>             Andrew
> 
> For Ethernet-type devices, the interface name will follow the standard
> convention: eth%d,
> For normal IP interfaces, the interface will be created as mhi_swip%d/
> mhi_hwip%d.
> The naming will depend on the details provided through struct mhi_device_info.

Take a look again at my question. Why is NET_NAME_PREDICTABLE correct?
Justify it. Especially given what alloc_etherdev_mqs() does.

	Andrew