netdev - RE: [Intel-wired-lan] [PATCH iwl-net v1] ixgbevf: fix link setup issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR11MB5902547E1110D253DE9BAA08F0A0A@PH0PR11MB5902.namprd11.prod.outlook.com>
Date: Wed, 10 Dec 2025 11:36:01 +0000
From: "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "stable@...r.kernel.org" <stable@...r.kernel.org>,
	"Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>, "Kwapulinski, Piotr"
	<piotr.kwapulinski@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v1] ixgbevf: fix link setup
 issue

From: Paul Menzel <pmenzel@...gen.mpg.de> 
Sent: Thursday, December 4, 2025 11:57 AM

>Dear Jedrzej,
>
>
>Thank you for your patch.
>
>Am 04.12.25 um 10:53 schrieb Jedrzej Jagielski:
>> It may happen that VF spawned for E610 adapter has problem with setting
>> link up. This happens when ixgbevf supporting mailbox API 1.6 coopearates
>
>cooperates
>
>> with PF driver which doesn't support this version of API, and hence
>> doesn't support new approach for getting PF link data.
>
>Which commit introduced the support for this API version?

Hi Paul, the one mentioned under the fixes tag.

>
>> In that case VF asks PF to provide link data but as PF doesn't support
>> it, returns -EOPNOTSUPP what leads to early bail from link configuration
>> sequence.
>> 
>> Avoid such situation by using legacy VFLINKS approach whenever negotiated
>> API version is less than 1.6.
>
>It’d be great, if you added how to exactly reproduce the issue.
>
>> Fixes: 53f0eb62b4d2 ("ixgbevf: fix getting link speed data for E610 devices")
>> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
>> Reviewed-by: Piotr Kwapulinski <piotr.kwapulinski@...el.com>
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
>> ---
>>   drivers/net/ethernet/intel/ixgbevf/vf.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c
>> index 29c5ce967938..8af88f615776 100644
>> --- a/drivers/net/ethernet/intel/ixgbevf/vf.c
>> +++ b/drivers/net/ethernet/intel/ixgbevf/vf.c
>> @@ -846,7 +846,8 @@ static s32 ixgbevf_check_mac_link_vf(struct ixgbe_hw *hw,
>>   	if (!mac->get_link_status)
>>   		goto out;