netdev - RE: [PATCH] epic100: remove module version and switch to module_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BY3PR18MB47070F7D806327202FEB4066A0A1A@BY3PR18MB4707.namprd18.prod.outlook.com>
Date: Thu, 11 Dec 2025 16:57:10 +0000
From: Sai Krishna Gajula <saikrishnag@...vell.com>
To: Ethan Nelson-Moore <enelsonmoore@...il.com>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: RE: [PATCH] epic100: remove module version and switch to
 module_pci_driver


> -----Original Message-----
> From: Ethan Nelson-Moore <enelsonmoore@...il.com>
> Sent: Thursday, December 11, 2025 1:19 PM
> To: netdev@...r.kernel.org
> Cc: Ethan Nelson-Moore <enelsonmoore@...il.com>
> Subject: [PATCH] epic100: remove module version and switch to
> module_pci_driver
> 
> The module version is useless, and the only thing the epic_init routine did
> besides pci_register_driver was to print the version. Signed-off-by: Ethan
> Nelson-Moore <enelsonmoore@ gmail. com> ---
> drivers/net/ethernet/smsc/epic100. c | 35 +----------------------------
> The module version is useless, and the only thing the epic_init routine did
> besides pci_register_driver was to print the version.
> 
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@...il.com>
> ---
>  drivers/net/ethernet/smsc/epic100.c | 35 +----------------------------
>  1 file changed, 1 insertion(+), 34 deletions(-)
> 
> diff --git a/drivers/net/ethernet/smsc/epic100.c
> b/drivers/net/ethernet/smsc/epic100.c
> index 45f703fe0e5a..389659db06a8 100644
> --- a/drivers/net/ethernet/smsc/epic100.c
> +++ b/drivers/net/ethernet/smsc/epic100.c
> @@ -26,8 +26,6 @@
>  */
> 
>  #define DRV_NAME        "epic100"
> -#define DRV_VERSION     "2.1"
> -#define DRV_RELDATE     "Sept 11, 2006"
> 
>  /* The user-configurable values.
>     These may be modified when a driver module is loaded.*/ @@ -89,12
> +87,6 @@ static int rx_copybreak;  #include <linux/uaccess.h>  #include
> <asm/byteorder.h>
> 
> -/* These identify the driver base version and may not be removed. */ -static
> char version[] = -DRV_NAME ".c:v1.11 1/7/2001 Written by Donald Becker
> <becker@...ld.com>"; -static char version2[] = -"  (unofficial 2.4.x kernel port,
> version " DRV_VERSION ", " DRV_RELDATE ")";
> -
>  MODULE_AUTHOR("Donald Becker <becker@...ld.com>");
> MODULE_DESCRIPTION("SMC 83c170 EPIC series Ethernet driver");
> MODULE_LICENSE("GPL"); @@ -329,11 +321,6 @@ static int
> epic_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	void *ring_space;
>  	dma_addr_t ring_dma;
> 
> -/* when built into the kernel, we only print version if device is found */ -
> #ifndef MODULE
> -	pr_info_once("%s%s\n", version, version2);
> -#endif
> -
>  	card_idx++;
> 
>  	ret = pci_enable_device(pdev);
> @@ -1393,7 +1380,6 @@ static void netdev_get_drvinfo (struct net_device
> *dev, struct ethtool_drvinfo *
>  	struct epic_private *np = netdev_priv(dev);
> 
>  	strscpy(info->driver, DRV_NAME, sizeof(info->driver));
> -	strscpy(info->version, DRV_VERSION, sizeof(info->version));
>  	strscpy(info->bus_info, pci_name(np->pci_dev), sizeof(info-
> >bus_info));  }
> 
> @@ -1564,23 +1550,4 @@ static struct pci_driver epic_driver = {
>  	.driver.pm	= &epic_pm_ops,
>  };
> 
> -
> -static int __init epic_init (void)
> -{
> -/* when a module, this is printed whether or not devices are found in probe
> */ -#ifdef MODULE
> -	pr_info("%s%s\n", version, version2);
> -#endif
> -
> -	return pci_register_driver(&epic_driver);
> -}
> -
> -
> -static void __exit epic_cleanup (void)
> -{
> -	pci_unregister_driver (&epic_driver);
> -}
> -
> -
> -module_init(epic_init);
> -module_exit(epic_cleanup);
> +module_pci_driver(epic_driver);
> --
> 2.43.0
> 
One downside is, users who previously relied on the printed epic100 version strings in dmesg, will no longer see them. 
Reviewed-by: Sai Krishna <saikrishnag@...vell.com>