netdev - Re: [PATCH net-next v1 1/3] dt-bindings: net: micrel: Convert to YAML schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTwsRiLJfHqjiLeh@eichest-laptop>
Date: Fri, 12 Dec 2025 15:52:54 +0100
From: Stefan Eichenberger <eichest@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, hkallweit1@...il.com,
	linux@...linux.org.uk, geert+renesas@...der.be,
	ben.dooks@...ethink.co.uk, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	francesco.dolcini@...adex.com, rafael.beims@...adex.com,
	Stefan Eichenberger <stefan.eichenberger@...adex.com>
Subject: Re: [PATCH net-next v1 1/3] dt-bindings: net: micrel: Convert to
 YAML schema

On Fri, Dec 12, 2025 at 02:16:14PM +0000, Simon Horman wrote:
> On Fri, Dec 12, 2025 at 09:46:16AM +0100, Stefan Eichenberger wrote:
> > From: Stefan Eichenberger <stefan.eichenberger@...adex.com>
> > 
> > Convert the devicetree bindings for the Micrel PHY to YAML schema. This
> > also combines the information from micrel.txt and micrel-ksz90x1.txt
> > into a single micrel.yaml file as this PHYs are from the same series.
> > Use yaml conditions to differentiate the properties that only apply to
> > specific PHY models.
> > 
> > Signed-off-by: Stefan Eichenberger <stefan.eichenberger@...adex.com>
> > ---
> >  .../bindings/net/micrel-ksz90x1.txt           | 228 --------
> >  .../devicetree/bindings/net/micrel.txt        |  57 --
> >  .../devicetree/bindings/net/micrel.yaml       | 527 ++++++++++++++++++
> >  3 files changed, 527 insertions(+), 285 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
> >  delete mode 100644 Documentation/devicetree/bindings/net/micrel.txt
> >  create mode 100644 Documentation/devicetree/bindings/net/micrel.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt b/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
> 
> ...
> 
> > -  Optional properties:
> > -
> > -    Maximum value of 1860, default value 900:
> > -
> > -      - rxc-skew-ps : Skew control of RX clock pad
> > -      - txc-skew-ps : Skew control of TX clock pad
> > -
> > -    Maximum value of 900, default value 420:
> > -
> > -      - rxdv-skew-ps : Skew control of RX CTL pad
> > -      - txen-skew-ps : Skew control of TX CTL pad
> > -      - rxd0-skew-ps : Skew control of RX data 0 pad
> > -      - rxd1-skew-ps : Skew control of RX data 1 pad
> > -      - rxd2-skew-ps : Skew control of RX data 2 pad
> > -      - rxd3-skew-ps : Skew control of RX data 3 pad
> > -      - txd0-skew-ps : Skew control of TX data 0 pad
> > -      - txd1-skew-ps : Skew control of TX data 1 pad
> > -      - txd2-skew-ps : Skew control of TX data 2 pad
> > -      - txd3-skew-ps : Skew control of TX data 3 pad
> > -
> > -    - micrel,force-master:
> > -        Boolean, force phy to master mode. Only set this option if the phy
> > -        reference clock provided at CLK125_NDO pin is used as MAC reference
> > -        clock because the clock jitter in slave mode is too high (errata#2).
> > -        Attention: The link partner must be configurable as slave otherwise
> > -        no link will be established.
> 
> Hi Stefan,
> 
> Sorry if this is off the mark, but Claude Code with
> https://github.com/masoncl/review-prompts/ flags
> that micrel,force-master is not included in the new .yaml
> schema and yet it is used in the driver (and I would add,
> several dts/dtsi files).
> 
> https://netdev-ai.bots.linux.dev/ai-review.html?id=2390d104-ff56-43f2-ba06-9650e8e5343b
> 

That's correct, I missed that one. I will fix that in the next version.
Thanks for pointing it out!

Regards,
Stefan