netdev - Re: [PATCH net 2/2] selftests: fib_nexthops: Add test case for ipv4 multi nexthops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d675cf53-8048-46b1-bd56-e3c15e2880bf@kernel.org>
Date: Mon, 15 Dec 2025 09:13:27 -0700
From: David Ahern <dsahern@...nel.org>
To: Ido Schimmel <idosch@...dia.com>,
 Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Willem de Bruijn <willemb@...gle.com>,
 Jakub Kicinski <kuba@...nel.ord>, Shuah Khan <shuah@...nel.org>,
 netdev@...r.kernel.org
Subject: Re: [PATCH net 2/2] selftests: fib_nexthops: Add test case for ipv4
 multi nexthops

On 12/14/25 11:59 PM, Ido Schimmel wrote:
> 
> fib_nexthops.sh is for tests using nexthop objects: "This test is for
> checking IPv4 and IPv6 FIB behavior with nexthop objects".
> 
> I suggest moving this to fib_tests.sh. See commit 4d0dac499bf3
> ("selftests/net: test tcp connection load balancing") that was added as
> a test for the blamed commit.

Good catch. Yes, these tests belong in fib_tests.sh, not fib_nexthops.sh