netdev - Re: [not-yet-signed PATCH] RDMA/core: flush gid_cache_wq WQ from disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251216140512.GC6079@nvidia.com>
Date: Tue, 16 Dec 2025 10:05:12 -0400
From: Jason Gunthorpe <jgg@...dia.com>
To: Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc: Leon Romanovsky <leon@...nel.org>, Majd Dibbiny <majd@...lanox.com>,
	Doug Ledford <dledford@...hat.com>,
	Yuval Shaia <yshaia@...vell.com>, Matan Barak <matanb@...lanox.com>,
	Bernard Metzler <bernard.metzler@...ux.dev>,
	OFED mailing list <linux-rdma@...r.kernel.org>,
	Network Development <netdev@...r.kernel.org>
Subject: Re: [not-yet-signed PATCH] RDMA/core: flush gid_cache_wq WQ from
 disable_device()

On Tue, Dec 16, 2025 at 10:29:29PM +0900, Tetsuo Handa wrote:
> Hmm, I misinterpreted that commit. Since ib_register_device() was doing
> 
> 	down_write(&lists_rwsem);
> 	list_add_tail(&device->core_list, &device_list);
> 	up_write(&lists_rwsem);
> 
> , it was
> 
> 	down_write(&lists_rwsem);
> 	list_del(&device->core_list);
> 
> in ib_unregister_device() that makes ib_enum_all_roce_netdevs() no longer
> call ib_enum_roce_netdev().
> 
> Then, calling ib_enum_all_roce_netdevs() asynchronously was always racy
> since commit 03db3a2d81e6 ("IB/core: Add RoCE GID table management") was added?

Yes, probably, it may need to grab the registration lock in the WQ.

Jason