netdev - Re: [PATCH net] net/smc: Initialize smc hashtables before registering users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aULLcudhF10_sZO6@linux.alibaba.com>
Date: Wed, 17 Dec 2025 23:25:38 +0800
From: Dust Li <dust.li@...ux.alibaba.com>
To: Alexandra Winter <wintera@...ux.ibm.com>,
	David Miller <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"D. Wythe" <alibuda@...ux.alibaba.com>,
	Sidraya Jayagond <sidraya@...ux.ibm.com>,
	Wenjia Zhang <wenjia@...ux.ibm.com>
Cc: netdev@...r.kernel.org, linux-s390@...r.kernel.org,
	Aswin Karuvally <aswin@...ux.ibm.com>,
	Heiko Carstens <hca@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Sven Schnelle <svens@...ux.ibm.com>,
	Simon Horman <horms@...nel.org>,
	Mahanta Jambigi <mjambigi@...ux.ibm.com>,
	Tony Lu <tonylu@...ux.alibaba.com>,
	Wen Gu <guwen@...ux.alibaba.com>, linux-rdma@...r.kernel.org,
	stable@...r.kernel.org,
	syzbot+f69bfae0a4eb29976e44@...kaller.appspotmail.com
Subject: Re: [PATCH net] net/smc: Initialize smc hashtables before
 registering users

On 2025-12-17 12:48:19, Alexandra Winter wrote:
>During initialisation of the SMC module initialize smc_v4/6_hashinfo before
>calling smc_nl_init(), proto_register() or sock_register(), to avoid a race
>that can cause use of an uninitialised pointer in case an smc protocol is
>called before the module is done initialising.
>
>syzbot report:
>KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f]
>Call Trace:
> <TASK>
> smc_diag_dump+0x59/0xa0 net/smc/smc_diag.c:236
> netlink_dump+0x647/0xd80 net/netlink/af_netlink.c:2325
> __netlink_dump_start+0x59f/0x780 net/netlink/af_netlink.c:2440
> netlink_dump_start include/linux/netlink.h:339 [inline]
> smc_diag_handler_dump+0x1ab/0x250 net/smc/smc_diag.c:251
> sock_diag_rcv_msg+0x3dc/0x5f0
> netlink_rcv_skb+0x1e3/0x430 net/netlink/af_netlink.c:2550
> netlink_unicast_kernel net/netlink/af_netlink.c:1331 [inline]
> netlink_unicast+0x7f0/0x990 net/netlink/af_netlink.c:1357
> netlink_sendmsg+0x8e4/0xcb0 net/netlink/af_netlink.c:1901


I don't think this is related to smc_nl_init().

Here the calltrace is smc_diag_dump(), which was registered in
sock_diag_register(&smc_diag_handler).

But smc_nl_init() is registering the general netlink in SMC,
which is unrelated to smc_diag_dump().

I think the root cause should be related to the initializing between
smc_diag.ko and smc_v4/6_hashinfo.ht.
The change in your previous patch 'dibs: Register smc as dibs_client'
may change the possiblity to this bug.

Best regards,
Dust

>
>Fixes: f16a7dd5cf27 ("smc: netlink interface for SMC sockets")
>Reported-by: syzbot+f69bfae0a4eb29976e44@...kaller.appspotmail.com
>Closes: https://syzkaller.appspot.com/bug?extid=f69bfae0a4eb29976e44
>Signed-off-by: Alexandra Winter <wintera@...ux.ibm.com>
>---
> net/smc/af_smc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
>index f97f77b041d9..b0f4405fb714 100644
>--- a/net/smc/af_smc.c
>+++ b/net/smc/af_smc.c
>@@ -3524,6 +3524,9 @@ static int __init smc_init(void)
> 		goto out_pernet_subsys_stat;
> 	smc_clc_init();
> 
>+	INIT_HLIST_HEAD(&smc_v4_hashinfo.ht);
>+	INIT_HLIST_HEAD(&smc_v6_hashinfo.ht);
>+
> 	rc = smc_nl_init();
> 	if (rc)
> 		goto out_ism;
>@@ -3581,8 +3584,6 @@ static int __init smc_init(void)
> 		pr_err("%s: sock_register fails with %d\n", __func__, rc);
> 		goto out_proto6;
> 	}
>-	INIT_HLIST_HEAD(&smc_v4_hashinfo.ht);
>-	INIT_HLIST_HEAD(&smc_v6_hashinfo.ht);
> 
> 	rc = smc_ib_register_client();
> 	if (rc) {
>-- 
>2.51.0