netdev - Re: [PATCH] net/handshake: duplicate handshake cancellations leak socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <176607061177.3000958.13778061126255337955.git-patchwork-notify@kernel.org>
Date: Thu, 18 Dec 2025 15:10:11 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Scott Mayhew <smayhew@...hat.com>
Cc: chuck.lever@...cle.com, kernel-tls-handshake@...ts.linux.dev,
 netdev@...r.kernel.org
Subject: Re: [PATCH] net/handshake: duplicate handshake cancellations leak
 socket

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Tue,  9 Dec 2025 14:30:15 -0500 you wrote:
> When a handshake request is cancelled it is removed from the
> handshake_net->hn_requests list, but it is still present in the
> handshake_rhashtbl until it is destroyed.
> 
> If a second cancellation request arrives for the same handshake request,
> then remove_pending() will return false... and assuming
> HANDSHAKE_F_REQ_COMPLETED isn't set in req->hr_flags, we'll continue
> processing through the out_true label, where we put another reference on
> the sock and a refcount underflow occurs.
> 
> [...]

Here is the summary with links:
  - net/handshake: duplicate handshake cancellations leak socket
    https://git.kernel.org/netdev/net/c/15564bd67e29

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html