netdev - Re: [net-next,PATCH v2 3/3] net: phy: realtek: Add property to enable SSC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b6cdd76-30a7-49be-8ccf-b90ede78b15a@mailbox.org>
Date: Thu, 18 Dec 2025 18:33:02 +0100
From: Marek Vasut <marek.vasut@...lbox.org>
To: Sai Krishna Gajula <saikrishnag@...vell.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
 Aleksander Jan Bajkowski <olek2@...pl>, Andrew Lunn <andrew@...n.ch>,
 Conor Dooley <conor+dt@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 Florian Fainelli <f.fainelli@...il.com>,
 Heiner Kallweit <hkallweit1@...il.com>, Ivan Galkin <ivan.galkin@...s.com>,
 Jakub Kicinski <kuba@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Michael Klein <michael@...sekall.de>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Russell King <linux@...linux.org.uk>,
 Vladimir Oltean <vladimir.oltean@....com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [net-next,PATCH v2 3/3] net: phy: realtek: Add property to enable
 SSC

On 12/11/25 7:39 PM, Sai Krishna Gajula wrote:

[...]

>> +	ret = phy_write_paged(phydev, RTL8211F_SSC_PAGE,
>> RTL8211F_SSC_RXC, 0x5f00);
>> +	if (ret < 0) {
>> +		dev_err(dev, "RXC SCC configuration failed: %pe\n",
>> ERR_PTR(ret));
>> +		return ret;
>> +	}
>> +
>> +	return 0;
>> +}
>> +
>> +static int rtl8211f_config_sysclk_ssc(struct phy_device *phydev) {
> 
> Minor nit:   Kernel style requires the opening brace on the next line, also in other places.
> static int rtl8211f_config_sysclk_ssc(struct phy_device *phydev)
> {
The patch looks correctly in lore archive, see:

https://lore.kernel.org/all/20251203210857.113328-3-marek.vasut@mailbox.org/

The patch also looks correctly in my mailer, it is only the 
aforementioned quoted text that seems mangled. Maybe your mailer did 
something odd with the patch ?