netdev - Re: [PATCH net 2/6] i40e: validate ring_len parameter against hardware-specific values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e39f4e4c-3b60-496f-9142-85b1570de3eb@amd.com>
Date: Wed, 17 Dec 2025 13:16:01 -0800
From: "Creeley, Brett" <bcreeley@....com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
 andrew+netdev@...n.ch, netdev@...r.kernel.org
Cc: Gregory Herrero <gregory.herrero@...cle.com>,
 Rafal Romanowski <rafal.romanowski@...el.com>,
 Aleksandr Loktionov <aleksandr.loktionov@...el.com>
Subject: Re: [PATCH net 2/6] i40e: validate ring_len parameter against
 hardware-specific values



On 12/17/2025 11:49 AM, Tony Nguyen wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> From: Gregory Herrero <gregory.herrero@...cle.com>
>
> The maximum number of descriptors supported by the hardware is
> hardware-dependent and can be retrieved using
> i40e_get_max_num_descriptors(). Move this function to a shared header
> and use it when checking for valid ring_len parameter rather than using
> hardcoded value.
>
> By fixing an over-acceptance issue, behavior change could be seen where
> ring_len could now be rejected while configuring rx and tx queues if its
> size is larger than the hardware-dependent maximum number of
> descriptors.
>
> Fixes: 55d225670def ("i40e: add validation for ring_len param")
> Signed-off-by: Gregory Herrero <gregory.herrero@...cle.com>
> Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>   drivers/net/ethernet/intel/i40e/i40e.h             | 11 +++++++++++
>   drivers/net/ethernet/intel/i40e/i40e_ethtool.c     | 12 ------------
>   drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c |  4 ++--
>   3 files changed, 13 insertions(+), 14 deletions(-)

LGTM.

Reviewed-by: Brett Creeley <brett.creeley@....com>
<snip>