netdev - Merging uli526x and dmfe drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADkSEUgY=eQz+0VWzAZwH6r6THHEgJaO1-SYemANZGaKEaWkOA@mail.gmail.com>
Date: Wed, 17 Dec 2025 21:15:16 -0800
From: Ethan Nelson-Moore <enelsonmoore@...il.com>
To: netdev@...r.kernel.org
Subject: Merging uli526x and dmfe drivers

I just noticed while investigating the state of lesser-used network
drivers that uli526x appears to be a fork of dmfe. They are so similar
that they could easily be merged (with the differences being selected
by the device ID, as dmfe already does), reducing future maintainer
workload.

This can easily be seen by:
cp uli526x.c uli526x_undo_rename.c
sed -i s/uli526x/dmfe/g uli526x_undo_rename.c
sed -i s/ULI526X/DMFE/g uli526x_undo_rename.c
sed -i s/uw32/dw32/g uli526x_undo_rename.c
sed -i s/ur32/dr32/g uli526x_undo_rename.c
sed -i 's/phy_read_/dmfe_&/g' uli526x_undo_rename.c
sed -i 's/phy_write_/dmfe_&/g' uli526x_undo_rename.c
diff -w dmfe.c uli526x_undo_rename.c

uli526x has get_link_ksettings support and dmfe does not, and they
have other small differences which might be bug fixes incorporated
into one but not the other.

Would patches to combine them be welcomed? If I were to do so, would
anyone be able to test the combined driver? I do not own the hardware.