netdev - RE: [Intel-wired-lan] [PATCH net 2/2] ice: drop udp_tunnel_get_rx_info() call from ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986C18EDD3FEFC285CB44CEE5A8A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Thu, 18 Dec 2025 10:38:33 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "mheib@...hat.com" <mheib@...hat.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"aduyck@...antis.com" <aduyck@...antis.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Keller, Jacob E" <jacob.e.keller@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH net 2/2] ice: drop
 udp_tunnel_get_rx_info() call from ndo_open()



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of mheib@...hat.com
> Sent: Wednesday, December 17, 2025 8:00 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>; davem@...emloft.net;
> aduyck@...antis.com; kuba@...nel.org; netdev@...r.kernel.org; Keller,
> Jacob E <jacob.e.keller@...el.com>; Mohammad Heib <mheib@...hat.com>
> Subject: [Intel-wired-lan] [PATCH net 2/2] ice: drop
> udp_tunnel_get_rx_info() call from ndo_open()
> 
> From: Mohammad Heib <mheib@...hat.com>
> 
> The ice driver calls udp_tunnel_get_rx_info() during
> ice_open_internal().
> This is redundant because UDP tunnel RX offload state is preserved
> across device down/up cycles. The udp_tunnel core handles
> synchronization automatically when required.
> 
> Furthermore, recent changes in the udp_tunnel infrastructure require
> querying RX info while holding the udp_tunnel lock. Calling it
> directly from the ndo_open path violates this requirement, triggering
> the lockdep warning.
> 
> Remove the redundant and unsafe call to ice_open_internal() to resolve
I think it should be "Remove the redundant and unsafe call to udp_tunnel_get_rx_info() from ice_open_internal()"?

> the locking violation.
> 
Please add lockdep trace evidence in the commit message.

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>

> Fixes: a4e82a81f573 ("ice: Add support for tunnel offloads")
> Signed-off-by: Mohammad Heib <mheib@...hat.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c
> b/drivers/net/ethernet/intel/ice/ice_main.c
> index 2533876f1a2f..1f94bdcbbba9 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -9633,9 +9633,6 @@ int ice_open_internal(struct net_device *netdev)
>  		netdev_err(netdev, "Failed to open VSI 0x%04X on switch
> 0x%04X\n",
>  			   vsi->vsi_num, vsi->vsw->sw_id);
> 
> -	/* Update existing tunnels information */
> -	udp_tunnel_get_rx_info(netdev);
> -
>  	return err;
>  }
> 
> --
> 2.52.0